[c++] include <cstdint> wherever uint8_t is used #6736
Merged
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today, I got an email from Prof. Brian Ripley (from CRAN):
Linking to these logs for a build of
lightgbm
with gcc-15: https://www.stats.ox.ac.uk/pub/bdr/gcc15/lightgbm.outIt contains compilation errors like this:
From the
gcc
docs (https://gcc.gnu.org/gcc-15/porting_to.html):There are more notes on this at https://gcc.gnu.org/gcc-15/porting_to.html
Notes for Reviewers
CI job?
I'm not sure how to get a development version of GCC 15 here in CI, to confirm that this is working. https://r-hub.github.io/containers/, for example, does not have a gcc-15 image yet.
If this PR passes all CI (which tests a wide range of compilers and operating systems), I think we should merge it and include it in the next release. Hopefully that will be sufficient.
We can test against gcc-15 as a separate effort.